Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.10.2/1.11] Custom models for compass/clock do not rotate #3264

Closed
HanPrower opened this issue Sep 19, 2016 · 10 comments
Closed

[1.10.2/1.11] Custom models for compass/clock do not rotate #3264

HanPrower opened this issue Sep 19, 2016 · 10 comments
Assignees
Labels
Bug This request reports or fixes a new or existing bug.

Comments

@HanPrower
Copy link

For some reason the override predicates for time and angle are ignored when fully custom models are used.

Attached is an example resourcepack (due to them being from PureBDcraft I've thrown random colour on the textures so as to not breach its license):
Forge_Compass-Clock.zip

@bs2609
Copy link
Contributor

bs2609 commented Sep 23, 2016

Just to clarify, does this work in vanilla Minecraft?

@HanPrower
Copy link
Author

Yes, it works perfectly fine in Vanilla MC.

@Actuarius
Copy link

@mezz added labels [Bug]

@Actuarius Actuarius added the Bug This request reports or fixes a new or existing bug. label Sep 24, 2016
@HanPrower
Copy link
Author

HanPrower commented Oct 26, 2016

Any news about this? Some pretty basic functionality being broken here.

@HanPrower
Copy link
Author

Still an issue in Forge for MC1.11.

@HanPrower HanPrower changed the title [1.10.2] Custom models for compass/clock do not rotate [1.10.2/1.11] Custom models for compass/clock do not rotate Dec 1, 2016
@HanPrower
Copy link
Author

@LexManos I see you assigned @RainWarrior back in October, but he hasn't made a commit since June.

I'm not sure if he's just the "models" guy or something, but is there any chance someone else can take a look at this and #3040 instead of it quietly being ignored?

It's some pretty core vanilla Minecraft stuff being broken.

@bs2609
Copy link
Contributor

bs2609 commented Dec 11, 2016

@RainWarrior (fry) is currently away, and has been for a while. They ought to be back on the 16th, so you might see some progress then.

It's also worth pinging @mezz, as they're coordinating issues/PRs now.

@mezz
Copy link
Contributor

mezz commented Dec 11, 2016

I do not have enough time right now to look into this myself, but I can review and help clean up a PR submitted by anyone in the community.

@williewillus
Copy link
Contributor

(ignore my prior post, I missed some of the logic in bakeNormal, which should make it work, so I have no idea why it doesn't)

@HanPrower
Copy link
Author

Nice thanks @RainWarrior 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This request reports or fixes a new or existing bug.
Projects
None yet
Development

No branches or pull requests

6 participants