[1.14.4] Custom banner patterns no longer work, additional patches needed.

[Darkhax]

Minecraft Version: 1.14.4
Forge Version: 28.0.45
Logs: https://gist.github.com/Darkhax/04275e38bf129ac90c54022455bd56c1

Steps to Reproduce:

1. Register a modded banner pattern.
2. Register a BannerPatternItem for the pattern.
3. The pattern will not be craftable in the loom normally.
4. Using the custom pattern item will crash the game with an out of bounds exception.

Description of issue:
With 1.14 banners were changed to use the Loom crafting block. The loom has default patterns that can be crafted with a dye, and stencil patterns which require a custom pattern item. For some reason Mojang decided to hard code this behavior based on the length of the pattern enum, and whether or not a pattern comes after a specific point. field_222480_O and field_222481_P. This means that all modded patterns will come after their position which means they will require a pattern item as well.

If the mod author does decide to add a pattern item anyway, trying to use that pattern item in the loom will crash the game. See the log for that stacktrace.

Note: Despite the banner pattern enum still having recipe shapes defined, all of these properties are no longer used by vanilla.

[stale]

This issue has been automatically marked as stale because it has not had activity in a long time. If this issue is still relevant and should remain open, please reply with a short explanation (e.g. "I have checked the code and this issue is still relevant because ___." or "Here's a screenshot of this issue on the latest version"). Thank you for your contributions!

[Darkhax]

Mojang has not changed the relevant code and no fixes have been implemented by Forge.

[stale]

This issue has been automatically marked as stale because it has not had activity in a long time. If this issue is still relevant and should remain open, please reply with a short explanation (e.g. "I have checked the code and this issue is still relevant because ___." or "Here's a screenshot of this issue on the latest version"). Thank you for your contributions!

[stale]

This issue has been automatically closed because it has not had activity in a long time. Please feel free to reopen it or create a new issue.