Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IExtensibleEnum in more enums. #6086

Closed
SilverDavidMC opened this issue Aug 25, 2019 · 5 comments
Closed

Implement IExtensibleEnum in more enums. #6086

SilverDavidMC opened this issue Aug 25, 2019 · 5 comments
Labels
Feature This request implements a new feature. Stale This request hasn't had an update from the author in a long time.

Comments

@SilverDavidMC
Copy link
Contributor

SilverDavidMC commented Aug 25, 2019 •
edited
Loading

Some enums don't currently use the IExtensibleEnum interface, making them not extendable when doing so would be useful. Two examples being:

SpellcastingIllagerEntity.SpellType
MusicTicker.MusicType
@SilverDavidMC SilverDavidMC added the Feature This request implements a new feature. label Aug 25, 2019
@alexbegt
Copy link

IExtensibleEnum is also needs to be added to PlantType as it got missed when the interface was added.

@LexManos
Copy link
Member

Make a list with proper justifications and we can consider it.
But we are NOT shotgunning it like we did in the past. It's a PITA and it doesn't help us provide a usecase to Mojang to make them NOT enums.

@stale
Copy link

stale bot commented Feb 24, 2020

This issue has been automatically marked as stale because it has not had activity in a long time. If this issue is still relevant and should remain open, please reply with a short explanation (e.g. "I have checked the code and this issue is still relevant because ___." or "Here's a screenshot of this issue on the latest version"). Thank you for your contributions!

@stale stale bot added the Stale This request hasn't had an update from the author in a long time. label Feb 24, 2020
@stale
Copy link

stale bot commented Mar 9, 2020

This issue has been automatically closed because it has not had activity in a long time. Please feel free to reopen it or create a new issue.

@stale stale bot closed this as completed Mar 9, 2020
@MakcSan
Copy link

MakcSan commented May 15, 2020

will this be fixed in future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature This request implements a new feature. Stale This request hasn't had an update from the author in a long time.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@LexManos @alexbegt @SilverDavidMC @MakcSan