Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IExtensibleEnum in more enums. #6086

Open
SilverDavidMC opened this issue Aug 25, 2019 · 2 comments
Open

Implement IExtensibleEnum in more enums. #6086

SilverDavidMC opened this issue Aug 25, 2019 · 2 comments
Labels

Comments

@SilverDavidMC
Copy link

@SilverDavidMC SilverDavidMC commented Aug 25, 2019

Some enums don't currently use the IExtensibleEnum interface, making them not extendable when doing so would be useful. Two examples being:

SpellcastingIllagerEntity.SpellType
MusicTicker.MusicType

@alexbegt

This comment has been minimized.

Copy link
Contributor

@alexbegt alexbegt commented Aug 27, 2019

IExtensibleEnum is also needs to be added to PlantType as it got missed when the interface was added.

@LexManos

This comment has been minimized.

Copy link
Member

@LexManos LexManos commented Aug 28, 2019

Make a list with proper justifications and we can consider it.
But we are NOT shotgunning it like we did in the past. It's a PITA and it doesn't help us provide a usecase to Mojang to make them NOT enums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.