Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different sized slimes all have the same eye height #7399

Closed
sekelsta opened this issue Oct 5, 2020 · 2 comments
Closed

Different sized slimes all have the same eye height #7399

sekelsta opened this issue Oct 5, 2020 · 2 comments

Comments

@sekelsta
Copy link

sekelsta commented Oct 5, 2020

Minecraft Version: 1.16.3

Forge Version: 1.16.3-34.1.10

Logs: {Link(s) to GitHub Gist with full latest.log and/or crash report}

Steps to Reproduce:

  1. Press F3 + B to show hitboxes
  2. /summon minecraft:slime ~ ~ ~ {Size:10}
  3. Observe eye height very low (compared to vanilla where it's about halfway up)
  4. (Optional): summon more sizes of slimes, and all appear to have the same eye height

Description of issue:
I think the issue may be in Entity.recalculateSize(), where it calculates eye height using the old size instead of the new one when creating the EntityEvent.Size event. Aside from the slimes, when I mod entities to have different sizes, they always have the same eye height no matter their size.

@sekelsta sekelsta added the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label Oct 5, 2020
@KnightMiner
Copy link
Contributor

Probably related to #7305

@diesieben07
Copy link
Contributor

Fixed with #7628

@autoforge autoforge bot removed the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants