Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadingErrorScreen inner headers are not centered #9687

Closed
zomabies opened this issue Jul 30, 2023 · 1 comment
Closed

LoadingErrorScreen inner headers are not centered #9687

zomabies opened this issue Jul 30, 2023 · 1 comment

Comments

@zomabies
Copy link

Minecraft Version: 1.19.2

Forge Version: 43.2.1

Logs: None

Steps to Reproduce:

  1. Add a ModLoadingWarning and a crash occurred later. Sample example is provided below.
@Mod("test")
public class ExampleMod {

    public ExampleMod() {

        final IModInfo modInfo = ModLoadingContext.get().getActiveContainer().getModInfo();
        final ModLoadingWarning modLoadingWarning = new ModLoadingWarning(
                modInfo,
                ModLoadingStage.CONSTRUCT,
                "TEST warn");
        ModLoader.get().addWarning(modLoadingWarning);

        throw new IllegalStateException("Test");
    }
}
  1. Wait for it to finish loading
  2. Both inner error and warning header in LoadingErrorScreen are not centered

Description of issue:

Both header should be centered as shown in #5530. It is possible this issue exists since 1.16 based on https://github.com/MinecraftForge/MinecraftForge/blame/6d15febdb35b5676b1795b2965d6eb527bb336e6/src/main/java/net/minecraftforge/fml/client/gui/screen/LoadingErrorScreen.java#L155

@zomabies zomabies added the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label Jul 30, 2023
@Ayush-Thakur-geek
Copy link

Ayush-Thakur-geek commented Oct 2, 2023

Hey @zomabies, I would like to work on this issue.

@autoforge autoforge bot removed the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants