Fix chat opacity #1225
Merged
Fix chat opacity #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clarifying comment added. |
|
Squash |
Add // FORGE comment As per convention, add // FORGE comment to clarify the purpose of the change
|
Squashed commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resinerts a GL11.glEnable(GL11.GL_BLEND) call that was present in Minecraft in 1.6.4 yet absent in Minecraft 1.7.x.
As a result of that absence, the chat opacity slider under multiplayer settings is nonfunctional - it changes the opacity of the gray chat background, but not the opacity of the chat words themselves.
This patch should have no side-effects, as it merely restores proper behavior from 1.6.4.
See: https://bugs.mojang.com/browse/MC-36812
To test: Type a message into chat, then slide the Chat Opacity slider around. Without the patch, only the gray background is faded in and out. With the patch, the words of the message are faded as well.