Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancelable event for Potions shifting the gui position #2662

Closed
wants to merge 1 commit into from

Conversation

mezz
Copy link
Contributor

@mezz mezz commented Mar 27, 2016

Allows mods to stop the InventoryEffectRenderer GuiContainers from moving around when potion effects are applied.

JEI Closed, default vanilla behavior:
2016-03-27_16 05 21

JEI Open, using the event to cancel the gui movement:
2016-03-27_16 05 24

@@ -159,6 +159,20 @@ public int getMouseY()
return mouseY;
}
}

/**
* This event fires in {@code InventoryEffectRenderer.updateActivePotionEffects()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a @link instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about javadoc syntax, I just copied the style I saw elsewhere in the file. Might be worth fixing up all the javadocs in another PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{@link InventoryEffectRenderer#updateActivePotionEffects}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing this documentation issue here: #2833

mezz added a commit to mezz/MinecraftForge that referenced this pull request Mar 28, 2016
@LexManos LexManos closed this Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants