Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fluid capability (master branch) #2942

Merged
merged 38 commits into from Jun 4, 2016

Conversation

mezz
Copy link
Contributor

@mezz mezz commented Jun 4, 2016

Updated version of #2923 that points to the master branch.

rwtema and others added 30 commits February 11, 2016 06:01
Removed EnumFacing sidedness. Also removed canDrain() and canFill() since these were used for checking connective-ness and are redundant now.
…an ItemStacks 'fluid' contents.

Essentially an update of ItemFluidContainer.
@mezz mezz mentioned this pull request Jun 4, 2016
@Actuarius
Copy link

Actuarius commented Jun 4, 2016

@mezz added labels [Feature]
@mezz added labels [Fluids]

@Actuarius Actuarius added Feature This request implements a new feature. Fluids This request touches or otherwise deals with the fluids system. These requests require special care. labels Jun 4, 2016
@LexManos LexManos merged commit 92914f8 into MinecraftForge:master Jun 4, 2016
@LexManos
Copy link
Member

LexManos commented Jun 4, 2016

@mezz Takes full responsibility for anything that breaks, yell at him.

@DiMuRie
Copy link

DiMuRie commented Jun 4, 2016

Hahah lol........

@CovertJaguar
Copy link
Contributor

Can't be any worse than the current state of Railcraft's fluid handling code. My own attempt to add support for IFluidItemContainer has been less than smooth. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This request implements a new feature. Fluids This request touches or otherwise deals with the fluids system. These requests require special care.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants