Fix async race condition on new chunks (closes #3020) #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a race condition that sometimes caused a just generated chunk to be generated a second time. In some this caused generated structures to appear incomplete such as in Issue #3020 when the second generated version effectively overwrote the original version of the chunk. This patch ensures when ProvideChunk calls LoadChunk synchronously we always attempt to load the chunk (if not cached) thus avoid the race condition without changing the logic for async loading for chunks already saved to disk. Thus this should retain the async functionality from PR #2946 while preventing generation issues caused by the race condition.
|
|
|
To help see the actual change, here is a side by side, makes reading/verifying this diff of a diff easier. |
This was referenced Jul 3, 2016
|
@mezz added labels [Bug] |
|
rebased to #3090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a race condition that sometimes caused a just generated chunk to be generated a second time. In some this caused generated structures to appear incomplete such as in Issue #3020 when the second generated version effectively overwrote the original version of the chunk.
This patch ensures when ProvideChunk calls LoadChunk synchronously we always attempt to load the chunk (if not cached) thus avoid the race condition without changing the logic for async loading for chunks already saved to disk.
Thus this should retain the async functionality from PR #2946 while preventing generation issues caused by the race condition.