Fix test mod IDs, names, and versions #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephcsible
force-pushed
the
fixourwarnings
branch
2 times, most recently
from
74342e4
to
9636c67
Compare
Most of our test mods have bad IDs (uppercase) and are missing names or versions. Forge produces a bunch of warnings in the console about this, which makes it more likely that an important message will be missed.
josephcsible
force-pushed
the
fixourwarnings
branch
from
9636c67
to
06ea5bf
Compare
|
Whoo not caring about world compatibility in test mods, protip kids if you change your MODIDs, make sure to write migration handlers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of our test mods have bad IDs (uppercase) and are missing names or
versions. Forge produces a bunch of warnings in the console about this, which
makes it more likely that an important message will be missed.