Fix very laggy mipmap slider MC-64581 #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mezz added labels [Vanilla Bug] |
Actuarius
added
the
Vanilla Bug
|
It might be simpler to move the Edit: also |
|
That might work, I'll give it a shot. |
|
Unfortunately it doesn't work well that way, The value's name isn't updated because |
P3pp3rF1y
pushed a commit
to P3pp3rF1y/MinecraftForge
that referenced
this pull request
Dec 1, 2016
P3pp3rF1y
pushed a commit
to P3pp3rF1y/MinecraftForge
that referenced
this pull request
Dec 2, 2016
|
im sorry, im using 2847 and this issue still persists |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.mojang.com/browse/MC-64581
When you move the Mipmap Levels slider in the Video Settings, Minecraft reloads all its textures and sounds immediately. This makes it very hard to change the level to what you want, the game is frozen until everything finishes reloading. If you try to drag the slider from one end to the other, it stops at each level to reload everything for some time.
This problem is made much worse by large texture packs or mods with many textures and sounds, the delay for moving the slider can be very long.
This PR makes is so that resources are only reloaded when you close the Video Options after you've messed with the mipmap control. This way players can move the control freely, and apply the new setting only once.