Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.11] Add a way to modify Entity AI #3615

Closed
wants to merge 1 commit into from
Closed

[1.11] Add a way to modify Entity AI #3615

wants to merge 1 commit into from

Conversation

Madsthunder
Copy link
Contributor

Added a way to modify Entity AI through an event. Works with any Entity as long as it has an instance of EntityAITasks.

@@ -171,6 +171,7 @@
@@ -108,6 +108,7 @@

protected void func_184651_r()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this named?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use the bot yourself to find out :P

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liach
Copy link
Contributor

liach commented Jan 8, 2017

You need to fix the merge conflict.

@williewillus
Copy link
Contributor

why are you calling the superclass initialization after the subclass initialization?

@liach
Copy link
Contributor

liach commented Jan 8, 2017

I would suggest modifying their AI only when they are added to the world. The patch is too big and meaningless.

@williewillus
Copy link
Contributor

I don't see much of a point to this to be honest ,we can already listen to entity spawn events and edit the task list using reflection. the patch is too big for the value it returns

@liach
Copy link
Contributor

liach commented Jan 8, 2017

Or to patch after the call of func_184651_r()

@simon816
Copy link
Contributor

simon816 commented Jan 8, 2017

@williewillus

why are you calling the superclass initialization after the subclass initialization?

Probably to allow vanilla to add it's AI tasks before the event is fired

@Madsthunder
Copy link
Contributor Author

Ah, didn't notice those events

@Madsthunder Madsthunder closed this Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants