[1.12] limit server>client ItemStack packet chattiness #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mezz
added
1.12
Capabilities
|
Tested and looks good to me. |
tterrag1098
pushed a commit
to tterrag1098/MinecraftForge
that referenced
this pull request
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to prevent server only itemstack changes triggering SPacketEntityEquipment and SPacketSetSlot from being triggered.
Currently when an itemstack changes in any way it always sends these packets to client even in cases where the change may not have changed the client stack - data in cap nbt or data not included in NBTShareTag.
So this change adds a condition in two places that checks if the client stack has actually changed and only in that case it allows the packets to be sent.
This is 1.12 version of #4045