Improve generation of normals for vanilla models #4313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before/after screenshots, using a superflat dirt world and the resource pack from #4178 (comment):
|
bs2609
changed the title
|
On a another note, the main cause of lossy floating point operations here is that the values aren't being unpacked to floats correctly. Updated the PR to fix this as well. |
mezz
added
1.12
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #4178.
Because of how the conversion was handled here, any float values even slightly less than 1 would have produced an output value of 126 instead of 127. This is why the rotated models were the ones affected, due to being subject to potentially lossy floating point operations.
Rounding the values to the closest whole number instead of simply truncating them should solve the issue.