Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cascading world gen in the Nether (MC-117810) #4400

Closed
wants to merge 2 commits into from

Conversation

bs2609
Copy link
Contributor

@bs2609 bs2609 commented Sep 14, 2017

Fix for MC-117810, just adds a +8 offset to the x and z coordinates, same as all the other non-WorldGenMineable populators.

@LexManos
Copy link
Member

Problem with Forge doing this is that it changes the locations of vanilla worldgen. And thats something we have to keep with vanilla.

@bs2609
Copy link
Contributor Author

bs2609 commented Sep 14, 2017

Had a slight bad feeling there was going to be a catch...

If it doesn't look like Mojang are going to fix this anytime soon, would this be acceptable if it was made a config option?

@LexManos
Copy link
Member

That might be a option. Opt-in to breaking vanilla worldgen compat.

@KingLemming
Copy link
Member

Honestly I think an opt-in is the ideal way to handle this, and it should be handled. :)

@raoulvdberge
Copy link
Contributor

If this is opt-in (almost) noone will toggle this flag, making this change useless.

@KingLemming
Copy link
Member

Can config options not be distributed with modpacks or something? This is far from useless, and keeps with a stated Forge goal of not actively jacking with vanilla.

@LexManos
Copy link
Member

LexManos commented Sep 15, 2017

Honestly, anyone who cares about runaway chunk generation enough to know what it is will know how to switch a flag.
Most people don't care that the game loads more chunks than it needs to. It uses a little more RAM, oh well.
I'm working on this, along with trying to find the other worldgen issues. It'll take me a little time.

@LexManos
Copy link
Member

0ad4218

@LexManos LexManos closed this Sep 16, 2017
@bs2609 bs2609 deleted the nether-worldgen-fix branch September 16, 2017 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants