Implemented LivingKnockBackEvent event and hook #4503
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,12 @@ | |
| import java.util.regex.Pattern; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| import javax.annotation.Nonnull; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| import org.apache.commons.io.FilenameUtils; | ||
| import org.apache.commons.io.IOUtils; | ||
|
There was a problem hiding this comment. You've reorganized the imports here, these lines have shifted place. Don't do this, it makes the patch files larger for no reason. There was a problem hiding this comment. This is a forge class. Imports should be added but not organized, its entirely up to the users IDE as to how they are ordered. There was a problem hiding this comment. So I don't have to organize them? There was a problem hiding this comment. No, don't organize them. (And you're right @covers1624 it's a Forge class, not a patch, I missed that, but it still needs to be fixed). |
||
|
|
||
| import com.google.common.collect.Lists; | ||
| import com.google.common.collect.Queues; | ||
| import com.google.common.collect.Sets; | ||
|
|
@@ -96,10 +102,10 @@ | |
| import net.minecraft.util.text.TextComponentString; | ||
| import net.minecraft.util.text.TextFormatting; | ||
| import net.minecraft.util.text.event.ClickEvent; | ||
| import net.minecraft.world.EnumDifficulty; | ||
| import net.minecraft.world.GameType; | ||
| import net.minecraft.world.IBlockAccess; | ||
| import net.minecraft.world.World; | ||
| import net.minecraft.world.storage.loot.LootEntry; | ||
| import net.minecraft.world.storage.loot.LootTable; | ||
| import net.minecraft.world.storage.loot.LootTableManager; | ||
|
|
@@ -120,6 +126,7 @@ | |
| import net.minecraftforge.event.entity.living.LivingEvent.LivingUpdateEvent; | ||
| import net.minecraftforge.event.entity.living.LivingFallEvent; | ||
| import net.minecraftforge.event.entity.living.LivingHurtEvent; | ||
| import net.minecraftforge.event.entity.living.LivingKnockBackEvent; | ||
| import net.minecraftforge.event.entity.living.LivingSetAttackTargetEvent; | ||
| import net.minecraftforge.event.entity.living.LootingLevelEvent; | ||
| import net.minecraftforge.event.entity.player.AnvilRepairEvent; | ||
|
|
@@ -141,12 +148,6 @@ | |
| import net.minecraftforge.registries.IForgeRegistry; | ||
| import net.minecraftforge.registries.RegistryManager; | ||
|
|
||
| public class ForgeHooks | ||
| { | ||
| //TODO: Loot tables? | ||
|
|
@@ -559,6 +560,13 @@ public static boolean onLivingAttack(EntityLivingBase entity, DamageSource src, | |
| return !MinecraftForge.EVENT_BUS.post(new LivingAttackEvent(entity, src, amount)); | ||
| } | ||
|
|
||
| public static LivingKnockBackEvent onLivingKnockBack(EntityLivingBase target, Entity attacker, float strength, double ratioX, double ratioZ) | ||
| { | ||
| LivingKnockBackEvent event = new LivingKnockBackEvent(target, attacker, strength, ratioX, ratioZ); | ||
| MinecraftForge.EVENT_BUS.post(event); | ||
| return event; | ||
| } | ||
|
|
||
| public static float onLivingHurt(EntityLivingBase entity, DamageSource src, float amount) | ||
| { | ||
| LivingHurtEvent event = new LivingHurtEvent(entity, src, amount); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have unused imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a patch, no touchy imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do I have to remove the unused imports or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Minecraft vanilla files do not ever touch imports, ever ever ever. You have added several, REMOVE THEM.