Fix multi-part model inventory rendering #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bs2609
reviewed
Dec 27, 2017
| private final Map<String, Pair<IModel, IModelState>> parts; | ||
|
|
||
| // for binary compatibility |
There was a problem hiding this comment.
If these aren't intended to be kept, except temporarily for compatibility, can you deprecate them and add a TODO: remove comment?
There was a problem hiding this comment.
Whole class is deprecated - for at least 3 major MC versions. But I can add TODO.
There was a problem hiding this comment.
If the whole thing is deprecated, then it's not such an issue.
boq
force-pushed
the
multi-model-default-state
branch
from
5d580ea
to
b0a42b2
Compare
boq
force-pushed
the
multi-model-default-state
branch
from
b0a42b2
to
704f0d0
Compare
mezz
added
the
Assigned
This was referenced Jan 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #4268 multi-part models (ones with
submodelsentry in blockstate) are rendered with transformation applied twice. This can be observed for example with test models from animation debug mod (spinning engine-thing) - in inventory it's smaller than expected and rotated at weird angle.Variant state (defined in
transformin JSON) currently is passed to model here (comment is invalid, state is applied to sub-models much later, during baking) and later used asIModel.getDefaultStatereturn, but is also applied here - directly from variant.Since other custom models don't know about variant transform, I'm removing that information from
MultiModeland keep it applied duringWeightedRandomModelconstruction - that way transform is applied to all models.Other models (custom or vanilla) are unaffected, since they pass through
ForgeVariant.processunaffected (see here).