[1.13.x] Refactor run configs based on my FG pr: MinecraftForge/ForgeGradle#546 #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2019
OhYea777
added a commit
to OhYea777/ForgeOCEP
that referenced
this pull request
Feb 16, 2019
OhYea777
changed the title
LexManos
reviewed
Feb 16, 2019
> Updated run config formats based on the refactored setup in my FG pr. > Removed old 'runclient' and 'runserver' JavaExec tasks, replacing them by creating the run configs using the refactored setup. > Update to set 'assetIndex' environment variable from FG.. > Updated MDK for new run config setup (it _should_ work without changing anything, however).
|
Resolved conflicts and simplified the MDK changes that I had originally made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of the combination of two of my other PR's: #5333 and #5471. I have closed those two PR's to centralize them into this.
This updates Forge's
build.gradlefile to better use the run config setup I have created in my FG pr: MinecraftForge/ForgeGradle#546. It also fixes the current issue of using the wrong asset index and now sets it based on the downloaded version meta from FG.I have also updated parts of the MDK to show, and describe, what can be done with the new run config setup. It also adds a test mod, using the MDK's test source set, to show the ability of multiple mods in a single project. Run configs should also be backwards compatible