Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an event for registering commands. closes #6968 #6969

Merged
merged 4 commits into from
Jul 15, 2020
Merged

Added an event for registering commands. closes #6968 #6969

merged 4 commits into from
Jul 15, 2020

Conversation

jaredlll08
Copy link
Contributor

No description provided.

@pupnewfster pupnewfster added 1.16 New Event This request implements a new event. labels Jul 13, 2020
@pupnewfster
Copy link
Member

Also if I recall the conversation that was had on discord, shouldn't this PR also be removing the FMLServerStartingEvent#getCommandDispatcher and also adjusting the JavaDocs on that class?

@pupnewfster pupnewfster added the BreakingChange This request includes a change that would break compatibility with current versions of Forge. label Jul 13, 2020
@Darkhax
Copy link
Contributor

Darkhax commented Jul 13, 2020 •
edited

This looks good to me.

@pupnewfster pupnewfster added the Assigned This request has been assigned to a core developer. Will not go stale. label Jul 13, 2020
@jaredlll08 jaredlll08 mentioned this pull request Jul 14, 2020
Closed
@LexManos LexManos merged commit 0001386 into MinecraftForge:1.16.x Jul 15, 2020
@NickPancakes NickPancakes mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexManos LexManos LexManos left review comments

@pupnewfster pupnewfster pupnewfster left review comments

Assignees

@LexManos LexManos

Labels
1.16 Assigned This request has been assigned to a core developer. Will not go stale. BreakingChange This request includes a change that would break compatibility with current versions of Forge. New Event This request implements a new event.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaredlll08 @pupnewfster @Darkhax @LexManos