Fix ClimberPathNavigator spinning when width is small. Closes #6993 #6997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichttt
added
1.16
Vanilla Bug
ichttt
reviewed
Jul 20, 2020
patches/minecraft/net/minecraft/pathfinding/ClimberPathNavigator.java.patch
Show resolved
Hide resolved
ichttt
added
the
Assigned
|
This isn't a proper fix, it should actually make the target position a Vec2D set to the center of the block, or the specific point it's trying to get to. If that was indeed the case then the bug would be gone. But sure, this fixes it within an acceptable margin of error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix (also kind of a hack) for #6993
Entities using
ClimberPathNavigator(like a spider) keep spinning at the end of their path navigation when their width is 0.9 or smaller.This PR makes sure when their width is checked for navigation that the width is never lower then 1.
.withinDistance(this.entity.getPositionVec(), (double)this.entity.getWidth())is now
.withinDistance(this.entity.getPositionVec(), Math.max((double)this.entity.getWidth(), 1.0D))