Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to call Pkg.update() before you add a package #167

Merged
merged 1 commit into from
May 30, 2022
Merged

No need to call Pkg.update() before you add a package #167

merged 1 commit into from
May 30, 2022

Conversation

navidcy
Copy link
Contributor

@navidcy navidcy commented Apr 28, 2022

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Docs: update installation instructions.

  • What is the current behavior? (You can also link to an open issue here)

Docs suggest that one needs to update all packages before adding QuantumESPRESSOBase

  • What is the new behavior (if this is a feature change)?

Drops the Pkg.update().

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Nope

  • Other information:

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #167 (bb36eed) into master (1699f6b) will decrease coverage by 1.21%.
The diff coverage is n/a.

❗ Current head bb36eed differs from pull request most recent head 29196f9. Consider uploading reports for the commit 29196f9 to get more accurate results

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   29.89%   28.67%   -1.22%     
==========================================
  Files          15       13       -2     
  Lines         562      558       -4     
==========================================
- Hits          168      160       -8     
- Misses        394      398       +4     
Impacted Files Coverage Δ
src/Inputs/PWscf/input.jl 70.83% <0.00%> (-8.34%) ⬇️
src/Inputs/Inputs.jl 30.00% <0.00%> (-6.37%) ⬇️
src/Inputs/PWscf/namelists.jl 81.25% <0.00%> (-1.79%) ⬇️
src/Inputs/PHonon/PHonon.jl 100.00% <0.00%> (ø)
src/Inputs/PWscf/PWscf.jl
src/QuantumESPRESSOBase.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1699f6b...29196f9. Read the comment docs.

@singularitti singularitti merged commit 6df0c49 into MineralsCloud:master May 30, 2022
@singularitti
Copy link
Member

Thanks @navidcy!

@navidcy navidcy deleted the patch-1 branch May 30, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants