ASP.NET Core 3.x: use Diagnostic bits #475
Conversation
This adds timings based on the DiagnosticListener bits overhauled in dotnet/aspnetcore#11730 with some further cleanup in dotnet/aspnetcore@b23ea5b This would also resolve #162 and #322.
| var action = descriptor.RouteValues.TryGetValue("action", out var a) ? a : "UnknownAction"; | ||
|
|
||
| // TODO: Don't allocate this string more than once | ||
| return label + ": " + controller + "/" + action; |
There was a problem hiding this comment.
Is there a reason to avoid using ActionDescriptor.DisplayName? This approach assumes everything is a controller, and possibly assumes that everything has a unique action/controller name (definitely not true).
ActionDescriptors all have a unique ID (not stable across launches) also
There was a problem hiding this comment.
Mainly just that it's so long, they'd all appear the same way in the UI (e.g. seeing namespaces and ...) - maybe I could take a reverse truncation? I need to store a map of these so we don't reallocate any approach per-request, that's just being wasteful for something we can assume is fairly finite. I could just make name -> short name in a dictionary here I suppose. Let me play and see what looks good!
There was a problem hiding this comment.
Pushed up a new version here - may play with the caching a bit, just still catching up across the board after being out last week so a bit slower than usual. Thanks for all the comments here! Hopefully I'll be able to dogfood on Stack Overflow this week to get some testing in.
Also puts the title for all cases on profiler steps. Not strictly related to this change (can PR the diff separately), but needed for the longer action names...so combining it. Also moves to CSS truncation instead of a magical number. Yay for modern browsers!
Makes action descriptor names a bit cleaner by removing the assembly name. Also caches so we only discard a cheaper tuple for lookup only. Could change to per-type methods and eliminate the tuple as well, or a dictionary based on key, or something else. Just depends how crazy we want to go here.
This adds timings based on the
DiagnosticListenerbits overhauled in dotnet/aspnetcore#11730 with some further cleanup in dotnet/aspnetcore@b23ea5bThis would also resolve #162 and #322.
Entirely possible there are more efficient ways to do the correlation tracking (I hope!) - putting this up for more eyes.
Example profiling:
cc @benaadams @rynowak @vcsjones