Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flamegraph toggle mode to the Badge UI, support for POST requests #220

Open
jeffblake opened this issue Mar 16, 2016 · 1 comment
Open
Assignees

Comments

@jeffblake
Copy link

I'm desiring a way to see flamegraph's for POST requests. I think it would be great to have a toggle mode in the Badge UI. It could insert a pp=flamegraph into the submitted form. Then the trick is redirecting to the flamegraph, or at least being able to see past flamegraphs in the UI that you can open. I heavily use IdentityCache, so the default SQL profiler isn't always useful since it seems to follow the path of SQL queries, not ruby code.

@SamSaffron
Copy link
Member

Totally support adding something here, catching the right POST may be hard
perhaps

  • Click profile next POST icon in pp help
  • Enter a regex for the path to profile
  • Next POST request to matched path will be flamegraphed
  • Add a link in pp help for last profiled POST flamegraph

Its not a trivial feature to build but sure would be useful.

On Wed, Mar 16, 2016 at 4:16 PM, jeffblake notifications@github.com wrote:

I'm desiring a way to see flamegraph's for POST requests. I think it would
be great to have a toggle mode in the Badge UI. It could insert a
pp=flamegraph into the submitted form. Then the trick is redirecting to
the flamegraph, or at least being able to see past flamegraphs in the UI
that you can open. I heavily use IdentityCache, so the default SQL
profiler isn't always useful since it seems to follow the path of SQL
queries, not ruby code.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants