Attempt to address discourse in a directory issue #25 #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
- Coverage 85.28% 85.22% -0.06%
==========================================
Files 21 21
Lines 1196 1198 +2
==========================================
+ Hits 1020 1021 +1
- Misses 176 177 +1
Continue to review full report at Codecov.
|
|
Thanks, let's try it out, looks like it could work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sam: This is a suggested patch to try to handle the Discourse issue that revived #25. It does not break my install (the whole application is run in a directory by passenger), and assumes both that the prior code worked and was necessary (action_controller.instance was defined for the mounted engine) so that all that is necessary to fix the issue is to compose the two variables.
How to run discourse in this configuration seemed pretty involved and under-documented, so reproducing the bug seemed tricky with nothing but your comment on #25 to go on.