Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md (authorization_mode config option details) #239

Closed
wants to merge 1 commit into from

Conversation

procommerz
Copy link

No description provided.

@codecov-io
Copy link

Current coverage is 82.89%

Merging #239 into master will not change coverage

@@             master       #239   diff @@
==========================================
  Files            21         21          
  Lines          1087       1087          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            901        901          
  Misses          186        186          
  Partials          0          0          

Powered by Codecov. Last updated by 79d6f93

@seanlinsley
Copy link
Contributor

This should be an easy merge. @SamSaffron?

@SamSaffron
Copy link
Member

Sorry I held back here cause we have:

https://github.com/MiniProfiler/rack-mini-profiler/blob/master/lib/mini_profiler_rails/railtie.rb#L35-L37

This is only needed if you are running in Dev OR not in Rails. Readme should clarify all of this stuff.

@olleolleolle
Copy link
Contributor

Would a line like this complete this PR?

"This is needed in all Rails environments except development and test."

@SamSaffron
Copy link
Member

yes please :)

@SamSaffron
Copy link
Member

thanks I added a note to clarify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants