Ruby Warnings #331
Merged
Ruby Warnings #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and actually this block variable `t` is not used inside the block
…ble_profiling not initialized
seems that the ivar was named wrongly at the very beginning at 4273771
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 89.18% 89.18% +<.01%
==========================================
Files 21 21
Lines 1220 1221 +1
==========================================
+ Hits 1088 1089 +1
Misses 132 132
Continue to review full report at Codecov.
|
|
Awesome, thanks heaps @amatsuda ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an attempt to fix some Ruby-level warnings that we see with
-wRuby option.