Allow Rack::MiniProfiler.config.pre_authorize_cb to be set in the app's initializer. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine to me, thanks ! |
SamSaffron
added a commit
that referenced
this pull request
Dec 5, 2013
Allow Rack::MiniProfiler.config.pre_authorize_cb to be set in the app's initializer.
fiedl
added a commit
to fiedl/wingolfsplattform
that referenced
this pull request
Dec 5, 2013
…equest. The pull request has been: MiniProfiler/rack-mini-profiler#35
|
FYI reverting: see #53 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the MiniProfiler is not active in the test environment.
We would like to make sure in an integration test that the tool can only be seen by developers. Therefore, we have tried to override this behavior.
Overriding this behavior in rails-app initializer did not work:
This tiny pull request changes this and allows
Rack::MiniProfiler.config.pre_authorize_cbto be set in an initializer. The default setting is only applied, ifpre_authorize_cbis not set in an initializer before.