Setting handlers, only if it is required by plugins #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a constant for hot_pluggable events, that are registered with the underlying C-code on-the-fly and deregistered if the last plugin of that event unloads
removed the default register_handler calls for the now hot_pluggable events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added the handle_frame event (called once per server frame, i.e. 40 times per second by default) and made the proposed events hot_pluggable, only registered with the C-code if there is an actual plugin making use of it - and deregistering the event if the last plugin that makes use of it unloads.
re: #124