Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npm ci #523

Merged
merged 1 commit into from
Jul 21, 2024
Merged

fix npm ci #523

merged 1 commit into from
Jul 21, 2024

Conversation

rubenmarcus
Copy link
Member

@rubenmarcus rubenmarcus commented Jul 21, 2024

PR Type

bug fix, enhancement


Description

  • Added npm install command before npm ci in the CI workflow to ensure package-lock.json is in sync.

Changes walkthrough 📝

Relevant files
Enhancement
branch-publish.yml
Add npm install step in CI workflow                                           

.github/workflows/branch-publish.yml

  • Added npm install command before npm ci to ensure package-lock.json is
    in sync.
  • +1/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @mintbase-codium-pr-agent
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    @mintbase-codium-pr-agent
    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Replace npm install with npm ci to ensure consistent dependency versions in CI environments

    Replace npm install with npm ci to ensure that the installation respects the exact
    versions defined in package-lock.json, which is more suitable for CI/CD environments
    to maintain consistency across installations.

    .github/workflows/branch-publish.yml [33]

    -npm install # Ensure package-lock.json is in sync
    +npm ci # Use npm ci to install exact versions from package-lock.json
     
    Suggestion importance[1-10]: 10

    Why: The suggestion to replace npm install with npm ci is valid and improves the consistency of dependency installations in CI/CD environments, which is crucial for maintaining reliability across different builds.

    10

    @rubenmarcus rubenmarcus merged commit fd6eea2 into beta Jul 21, 2024
    2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant