-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move generated protocol code to build directory #2300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly in favour, with only maybe-improvements as comments.
Not borsing yet, as I think we've decided in Mattermost that we need specific generator tests before landing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it blends, let it.
bors merge
2300: Move generated protocol code to build directory r=Saviq a=wmww This removes generated Wayland protocol code from the project source, and instead always generates these files as part of the build process (as discussed on mattermost) Co-authored-by: William Wold <wm@wmww.sh> Co-authored-by: Alan Griffiths <alan@octopull.co.uk> Co-authored-by: Michał Sawicz <michal.sawicz@canonical.com>
No, because
Might be an easy fix, I didn't play around with it long enough to find it. |
7b052ad
to
f526a40
Compare
Once more, with feeling then. bors merge |
bors cancel |
bors r- |
There's a couple places |
bors r=Saviq |
2300: Move generated protocol code to build directory r=Saviq a=wmww This removes generated Wayland protocol code from the project source, and instead always generates these files as part of the build process (as discussed on mattermost) Co-authored-by: William Wold <wm@wmww.sh> Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
I think bors forgot what it was doing! bors retry |
One moar time. bors r- |
Canceled. |
bors merge |
2423: Release 2.8.0 r=AlanGriffiths,graysonguarino,RAOF,wmww,Saviq a=Saviq --- > - ABI summary: > - miral ABI unchanged at 4 > - mircommon ABI bumped to 9 > - mircookie ABI unchanged at 2 > - mircore ABI unchanged at 1 > - miroil ABI unchanged at 1 > - mirplatform ABI unchanged at 23 > - mirserver ABI bumped to 58 > - mirwayland ABI unchanged at 3 > - mirplatformgraphics ABI bumped to 20 > - mirinputplatform ABI unchanged at 8 > - Enhancements: > - Move generated protocol code to build directory (#2300) > - Allow --app-env-amend to be supplied multiple times (#2333) > - Make window title a configuration option (#2349) > - Add fatal_error if unable to bind Wayland socket (#2350) > - Add `mold` to the list of supported linkers (#2353) > - Platform refactoring towards hybrid GPU support (#2358, #2378, #2407) > - Implement wlr_screencopy_unstable_v1 for screenshots (#2383) > - Refactor out mf::MirDisplay (#2406) > - Bugs fixed: > - Synchronize buffer swaps to video frame in egl spinner (Fixes #2154) > - Do not give menus keyboard focus (Fixes #2324) > - Refactor Wayland keyboard input (Fixes #2331) > - Further simplify and correct keyboard focus setting (Fixes #2338) > - wl_pointer: do not send events when not compatible (Fixes #2341) > - Kill clients with error instead of sending unsupported (Fixes #2343) > - Initialize sig_handler_desc.sa_mask (#2386) > - Fix ThreadedDispatcherSignalTest.keeps_dispatching... (Fixes #2377) Co-authored-by: Michał Sawicz <michal@sawicz.net> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
This removes generated Wayland protocol code from the project source, and instead always generates these files as part of the build process (as discussed on mattermost)