Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mir_wayland_generator generated code that include non public header #2804

Closed
mariogrip opened this issue Jan 22, 2023 · 1 comment · Fixed by #2805
Closed

mir_wayland_generator generated code that include non public header #2804

mariogrip opened this issue Jan 22, 2023 · 1 comment · Fixed by #2805

Comments

@mariogrip
Copy link
Contributor

When generating code with mir_wayland_generator it creates code that include #include "mir/wayland/client.h" but this is not an public header.
@AlanGriffiths AlanGriffiths mentioned this issue Jan 22, 2023
Merged
@AlanGriffiths
Copy link
Contributor

Oops!

@bors bors bot closed this as completed in 2ecda2e Jan 22, 2023
Saviq pushed a commit that referenced this issue Feb 23, 2023
@bors @AlanGriffiths @Saviq
Merge #2805
fb1f903 
2805: Publish mir/wayland/client.h r=Saviq a=AlanGriffiths

Fixes: #2804

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
bors bot added a commit that referenced this issue Feb 27, 2023
@bors @Saviq
Merge #2846
ccd4eb2 
2846: Release 2.12.1 r=AlanGriffiths a=Saviq

    - Bugs fixed:
      . Add missing #include statements (#2802)
      . mir_wayland_generator generated code that include non public
        header (#2804)
      . Building docs fails when trying to not remove doc/html/cppguide (#2800)
      . wayland: Add missing cstdint includes (#2821)
      . Enabling zwp_idle_inhibit_manager_v1 causes Mir to crash with some
        applications (#2836)
      . [Wayland] idle_inhibit_unstable_v1 is badly broken (#2838)

Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Michał Sawicz (Saviq) <michal@sawicz.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish mir/wayland/client.h canonical/mir
2 participants
@mariogrip @AlanGriffiths