Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building docs fails when trying to not remove doc/html/cppguide: Is a directory #2800

Closed
OPNA2608 opened this issue Jan 20, 2023 · 2 comments · Fixed by #2817
Closed

Building docs fails when trying to not remove doc/html/cppguide: Is a directory #2800

OPNA2608 opened this issue Jan 20, 2023 · 2 comments · Fixed by #2817
Assignees
@Saviq

Comments

@OPNA2608
Copy link
Contributor

On Mir 2.12.0 / since #2728, the doc target runs

rm -f  ${CMAKE_BINARY_DIR}/doc/html/{*,search}

in an effort to not delete the just-generated cppguide directory. Unfortunately this seems to error out on my machine because rm -f only handles missing paths gracefully, not directories (or i.e. lack of permissions):
image

So this stops the build:

[  0%] Generating ../doc/html/cppguide/styleguide.css
[100%] Generating ../doc/html/cppguide/index.html
[100%] Built target guides
rm: cannot remove '/build/source/build/doc/html/cppguide': Is a directory
make[3]: *** [CMakeFiles/doc.dir/build.make:70: CMakeFiles/doc] Error 1
make[2]: *** [CMakeFiles/Makefile2:2048: CMakeFiles/doc.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:2055: CMakeFiles/doc.dir/rule] Error 2
make: *** [Makefile:179: doc] Error 2
error: builder for '/nix/store/sjm09f0xf5pci3b5cdmv7yw7ivc6qv4f-mir-2.12.0.drv' failed with exit code 2;
@OPNA2608
Copy link
Contributor Author 

rm -f  ${CMAKE_BINARY_DIR}/doc/html/{*,search} || true

This seems to work better.

@AlanGriffiths
Copy link
Contributor

This appears to be a change in rm behaviour. I'll come up with a more elegant solution

@Saviq Saviq self-assigned this Jan 30, 2023
@Saviq Saviq mentioned this issue Jan 31, 2023
Merged
bors bot added a commit that referenced this issue Jan 31, 2023
@bors @Saviq
Merge #2817
0489253 
2817: doc: better removal of existing docs r=AlanGriffiths a=Saviq

`rm -f dir` doesn't do.

Fixes: #2800

Co-authored-by: Michał Sawicz (Saviq) <michal@sawicz.net>
@bors bors bot closed this as completed in df0e7b7 Jan 31, 2023
AlanGriffiths pushed a commit that referenced this issue Feb 9, 2023
@Saviq @AlanGriffiths
doc: better removal of existing docs
741fae9 
`rm -f dir` doesn't do.

Fixes: #2800
Saviq added a commit that referenced this issue Feb 23, 2023
@bors @Saviq
Merge #2817
c6f6ff9 
2817: doc: better removal of existing docs r=AlanGriffiths a=Saviq

`rm -f dir` doesn't do.

Fixes: #2800

Co-authored-by: Michał Sawicz (Saviq) <michal@sawicz.net>
bors bot added a commit that referenced this issue Feb 27, 2023
@bors @Saviq
Merge #2846
ccd4eb2 
2846: Release 2.12.1 r=AlanGriffiths a=Saviq

    - Bugs fixed:
      . Add missing #include statements (#2802)
      . mir_wayland_generator generated code that include non public
        header (#2804)
      . Building docs fails when trying to not remove doc/html/cppguide (#2800)
      . wayland: Add missing cstdint includes (#2821)
      . Enabling zwp_idle_inhibit_manager_v1 causes Mir to crash with some
        applications (#2836)
      . [Wayland] idle_inhibit_unstable_v1 is badly broken (#2838)

Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Michał Sawicz (Saviq) <michal@sawicz.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Saviq Saviq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: better removal of existing docs canonical/mir
3 participants
@Saviq @AlanGriffiths @OPNA2608