Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wayland] idle_inhibit_unstable_v1 is badly broken #2838

Closed
AlanGriffiths opened this issue Feb 15, 2023 · 1 comment · Fixed by #2842
Closed

[Wayland] idle_inhibit_unstable_v1 is badly broken #2838

AlanGriffiths opened this issue Feb 15, 2023 · 1 comment · Fixed by #2842
Assignees
@AlanGriffiths
Labels
bug

Comments

@AlanGriffiths
Copy link
Contributor

  1. zwp_idle_inhibit_manager_v1.create_inhibitor does not create a zwp_idle_inhibitor_v1 unless the surface has input focus (it should always create an inhibitor)
  2. zwp_idle_inhibitor_v1 does not release and (re)acquire the wake lock according to the surface's "visual relevance"
@AlanGriffiths
Copy link
Contributor Author

Point 1 is the cause for the crash reported in #2836

@AlanGriffiths AlanGriffiths self-assigned this Feb 15, 2023
@AlanGriffiths AlanGriffiths mentioned this issue Feb 16, 2023
Closed
@wmww wmww mentioned this issue Feb 17, 2023
Merged
@bors bors bot closed this as completed in 5f634e3 Feb 21, 2023
Saviq pushed a commit that referenced this issue Feb 23, 2023
@bors @AlanGriffiths
@wmww @Saviq
Merge #2842
c44c2f3 
2842: (Sophie's) reimplementation of idle_inhibit_unstable_v1 r=AlanGriffiths a=wmww

Based on and alternative to #2839. I put the visibility observer in idle_inhibit_v1.cpp to avoid cluttering wl_surface.cpp. Draft since there's still some issues I've observed and want to sort out. Not yet clear if they're also in our current implementation and/or Alan's implementation.

Fixes #2838
Fixes #2836

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Co-authored-by: Sophie Winter <wm@wmww.sh>
bors bot added a commit that referenced this issue Feb 27, 2023
@bors @Saviq
Merge #2846
ccd4eb2 
2846: Release 2.12.1 r=AlanGriffiths a=Saviq

    - Bugs fixed:
      . Add missing #include statements (#2802)
      . mir_wayland_generator generated code that include non public
        header (#2804)
      . Building docs fails when trying to not remove doc/html/cppguide (#2800)
      . wayland: Add missing cstdint includes (#2821)
      . Enabling zwp_idle_inhibit_manager_v1 causes Mir to crash with some
        applications (#2836)
      . [Wayland] idle_inhibit_unstable_v1 is badly broken (#2838)

Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Michał Sawicz (Saviq) <michal@sawicz.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlanGriffiths AlanGriffiths

Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@AlanGriffiths