Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing #include statements #2802

Merged
merged 1 commit into from Jan 20, 2023
Merged

Add missing #include statements #2802

merged 1 commit into from Jan 20, 2023

Conversation

musicinmybrain
Copy link
Contributor

@musicinmybrain musicinmybrain commented Jan 20, 2023 •
edited

  • <stdexcept> for std::logic_error
  • <cstdint> for uint*_t

Fixes failure to compile with GCC 13.

@musicinmybrain
Add missing #include statements
3e101c1 
- <stdexcept> for std::logic_error
- <cstdint> for uint*_t

Fixes failure to compile with GCC 13.
wmww
wmww approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@wmww wmww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
bors r+

@bors
Copy link
Contributor

bors bot commented Jan 20, 2023

Build succeeded:

@bors bors bot merged commit 7938b61 into canonical:main Jan 20, 2023
Saviq pushed a commit that referenced this pull request Feb 23, 2023
@bors @musicinmybrain @Saviq
Merge #2802
e58c09d 
2802: Add missing #include statements r=wmww a=musicinmybrain

- `<stdexcept>` for `std::logic_error`
- `<cstdint>` for `uint*_t`

Fixes failure to compile with GCC 13.

Co-authored-by: Benjamin A. Beasley <code@musicinmybrain.net>
bors bot added a commit that referenced this pull request Feb 27, 2023
@bors @Saviq
Merge #2846
ccd4eb2 
2846: Release 2.12.1 r=AlanGriffiths a=Saviq

    - Bugs fixed:
      . Add missing #include statements (#2802)
      . mir_wayland_generator generated code that include non public
        header (#2804)
      . Building docs fails when trying to not remove doc/html/cppguide (#2800)
      . wayland: Add missing cstdint includes (#2821)
      . Enabling zwp_idle_inhibit_manager_v1 causes Mir to crash with some
        applications (#2836)
      . [Wayland] idle_inhibit_unstable_v1 is badly broken (#2838)

Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Michał Sawicz (Saviq) <michal@sawicz.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmww wmww wmww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@musicinmybrain @wmww