fix: adding a check to make sure asset id isn't created from empty st…

…ring
MirageNet · Nov 7, 2021 · 26a5bbc · 26a5bbc
1 parent bc5da6a
commit 26a5bbc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/Assets/Mirage/Runtime/NetworkIdentity.cs b/Assets/Mirage/Runtime/NetworkIdentity.cs
@@ -257,7 +257,8 @@ public int PrefabHash
             {
 #if UNITY_EDITOR
                 // This is important because sometimes OnValidate does not run (like when adding view to prefab with no child links)
-                if (_prefabHash == 0)
+                // also check for hash that is empty string, if it is, reset its ID to its real path
+                if (_prefabHash == 0 || _prefabHash == StringHash.EmptyString)
                     SetupIDs();
 #endif
                 return _prefabHash;
@@ -416,6 +417,11 @@ void OnValidate()
 
         void AssignAssetID(string path)
         {
+            if (string.IsNullOrEmpty(path))
+            {
+                return;
+            }
+
             _prefabHash = path.GetStableHashCode();
         }
 

diff --git a/Assets/Mirage/Runtime/StringHash.cs b/Assets/Mirage/Runtime/StringHash.cs
@@ -2,6 +2,8 @@ namespace Mirage
 {
     public static class StringHash
     {
+        public const int EmptyString = 23;
+
         /// <summary>
         /// Gets a hash for a string. This hash will be the same on all platforms 
         /// </summary>
@@ -12,7 +14,7 @@ public static int GetStableHashCode(this string text)
         {
             unchecked
             {
-                int hash = 23;
+                int hash = EmptyString;
                 foreach (char c in text)
                     hash = hash * 31 + c;
                 return hash;