-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixing defines for Unity2021.2 #977
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
James-Frowen
force-pushed
the
defines-2021
branch
from
October 28, 2021 12:08
1cc86bb
to
13975c8
Compare
James-Frowen
force-pushed
the
defines-2021
branch
from
November 7, 2021 15:13
13975c8
to
be0367b
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2021
# [112.0.0](v111.1.1...v112.0.0) (2021-11-07) ### Bug Fixes * adding a check to make sure asset id isn't created from empty string ([26a5bbc](26a5bbc)) * fixing defines for Unity2021.2 ([#977](#977)) ([15ffa5b](15ffa5b)) * fixing id generation for negative numbers ([f5e1b9a](f5e1b9a)) * renameing identity.Reset so it doesn't override unity's reset function ([bc5da6a](bc5da6a)) * using hex for logging prefabhash and sceneid ([f0c335f](f0c335f)) ### Code Refactoring * **NetworkIdentity:** moving id generation to its own file ([51795ce](51795ce)) ### Features * **NetworkIdentity:** adding helper methods for Id ([0ddfdb8](0ddfdb8)) * **ServerObjectManager:** adding AddCharacter method that takes Identity and hash ([629036a](629036a)) * **ServerObjectManager:** adding ReplaceCharacter method that takes Identity and hash ([4320c05](4320c05)) ### Performance Improvements * making transform values option to send with spawn message ([#972](#972)) ([22e7dcd](22e7dcd)) * no longer sending PrefabHash if the object is a scene id ([46e29a6](46e29a6)) ### BREAKING CHANGES * Scene objects based on a prefab will no longer have their PrefabHash set on spawn on the client * **NetworkIdentity:** Scene Id generation is no longer public
🎉 This PR is included in version 112.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dragonslaya84
pushed a commit
that referenced
this pull request
Nov 7, 2021
dragonslaya84
pushed a commit
that referenced
this pull request
Nov 7, 2021
# [112.0.0](v111.1.1...v112.0.0) (2021-11-07) ### Bug Fixes * adding a check to make sure asset id isn't created from empty string ([26a5bbc](26a5bbc)) * fixing defines for Unity2021.2 ([#977](#977)) ([15ffa5b](15ffa5b)) * fixing id generation for negative numbers ([f5e1b9a](f5e1b9a)) * renameing identity.Reset so it doesn't override unity's reset function ([bc5da6a](bc5da6a)) * using hex for logging prefabhash and sceneid ([f0c335f](f0c335f)) ### Code Refactoring * **NetworkIdentity:** moving id generation to its own file ([51795ce](51795ce)) ### Features * **NetworkIdentity:** adding helper methods for Id ([0ddfdb8](0ddfdb8)) * **ServerObjectManager:** adding AddCharacter method that takes Identity and hash ([629036a](629036a)) * **ServerObjectManager:** adding ReplaceCharacter method that takes Identity and hash ([4320c05](4320c05)) ### Performance Improvements * making transform values option to send with spawn message ([#972](#972)) ([22e7dcd](22e7dcd)) * no longer sending PrefabHash if the object is a scene id ([46e29a6](46e29a6)) ### BREAKING CHANGES * Scene objects based on a prefab will no longer have their PrefabHash set on spawn on the client * **NetworkIdentity:** Scene Id generation is no longer public
dragonslaya84
pushed a commit
that referenced
this pull request
Nov 7, 2021
dragonslaya84
pushed a commit
that referenced
this pull request
Nov 7, 2021
# [112.0.0](v111.1.1...v112.0.0) (2021-11-07) ### Bug Fixes * adding a check to make sure asset id isn't created from empty string ([26a5bbc](26a5bbc)) * fixing defines for Unity2021.2 ([#977](#977)) ([15ffa5b](15ffa5b)) * fixing id generation for negative numbers ([f5e1b9a](f5e1b9a)) * renameing identity.Reset so it doesn't override unity's reset function ([bc5da6a](bc5da6a)) * using hex for logging prefabhash and sceneid ([f0c335f](f0c335f)) ### Code Refactoring * **NetworkIdentity:** moving id generation to its own file ([51795ce](51795ce)) ### Features * **NetworkIdentity:** adding helper methods for Id ([0ddfdb8](0ddfdb8)) * **ServerObjectManager:** adding AddCharacter method that takes Identity and hash ([629036a](629036a)) * **ServerObjectManager:** adding ReplaceCharacter method that takes Identity and hash ([4320c05](4320c05)) ### Performance Improvements * making transform values option to send with spawn message ([#972](#972)) ([22e7dcd](22e7dcd)) * no longer sending PrefabHash if the object is a scene id ([46e29a6](46e29a6)) ### BREAKING CHANGES * Scene objects based on a prefab will no longer have their PrefabHash set on spawn on the client * **NetworkIdentity:** Scene Id generation is no longer public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.