Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing defines for Unity2021.2 #977

Merged
merged 1 commit into from
Nov 7, 2021
Merged

fix: fixing defines for Unity2021.2 #977

merged 1 commit into from
Nov 7, 2021

Conversation

James-Frowen
Copy link
Member

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the has conflicts Pull Request has merge conflicts label Nov 7, 2021
@James-Frowen James-Frowen merged commit 15ffa5b into master Nov 7, 2021
@James-Frowen James-Frowen deleted the defines-2021 branch November 7, 2021 15:13
github-actions bot pushed a commit that referenced this pull request Nov 7, 2021
# [112.0.0](v111.1.1...v112.0.0) (2021-11-07)

### Bug Fixes

* adding a check to make sure asset id isn't created from empty string ([26a5bbc](26a5bbc))
* fixing defines for Unity2021.2 ([#977](#977)) ([15ffa5b](15ffa5b))
* fixing id generation for negative numbers ([f5e1b9a](f5e1b9a))
* renameing identity.Reset so it doesn't override unity's reset function ([bc5da6a](bc5da6a))
* using hex for logging prefabhash and sceneid ([f0c335f](f0c335f))

### Code Refactoring

* **NetworkIdentity:** moving id generation to its own file ([51795ce](51795ce))

### Features

* **NetworkIdentity:** adding helper methods for Id ([0ddfdb8](0ddfdb8))
* **ServerObjectManager:** adding AddCharacter method that takes Identity and hash ([629036a](629036a))
* **ServerObjectManager:** adding ReplaceCharacter method  that takes Identity and hash ([4320c05](4320c05))

### Performance Improvements

* making transform values option to send with spawn message ([#972](#972)) ([22e7dcd](22e7dcd))
* no longer sending PrefabHash if the object is a scene id ([46e29a6](46e29a6))

### BREAKING CHANGES

* Scene objects based on a prefab will no longer have their PrefabHash set on spawn on the client
* **NetworkIdentity:** Scene Id generation is no longer public
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2021

🎉 This PR is included in version 112.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dragonslaya84 pushed a commit that referenced this pull request Nov 7, 2021
# [112.0.0](v111.1.1...v112.0.0) (2021-11-07)

### Bug Fixes

* adding a check to make sure asset id isn't created from empty string ([26a5bbc](26a5bbc))
* fixing defines for Unity2021.2 ([#977](#977)) ([15ffa5b](15ffa5b))
* fixing id generation for negative numbers ([f5e1b9a](f5e1b9a))
* renameing identity.Reset so it doesn't override unity's reset function ([bc5da6a](bc5da6a))
* using hex for logging prefabhash and sceneid ([f0c335f](f0c335f))

### Code Refactoring

* **NetworkIdentity:** moving id generation to its own file ([51795ce](51795ce))

### Features

* **NetworkIdentity:** adding helper methods for Id ([0ddfdb8](0ddfdb8))
* **ServerObjectManager:** adding AddCharacter method that takes Identity and hash ([629036a](629036a))
* **ServerObjectManager:** adding ReplaceCharacter method  that takes Identity and hash ([4320c05](4320c05))

### Performance Improvements

* making transform values option to send with spawn message ([#972](#972)) ([22e7dcd](22e7dcd))
* no longer sending PrefabHash if the object is a scene id ([46e29a6](46e29a6))

### BREAKING CHANGES

* Scene objects based on a prefab will no longer have their PrefabHash set on spawn on the client
* **NetworkIdentity:** Scene Id generation is no longer public
dragonslaya84 pushed a commit that referenced this pull request Nov 7, 2021
# [112.0.0](v111.1.1...v112.0.0) (2021-11-07)

### Bug Fixes

* adding a check to make sure asset id isn't created from empty string ([26a5bbc](26a5bbc))
* fixing defines for Unity2021.2 ([#977](#977)) ([15ffa5b](15ffa5b))
* fixing id generation for negative numbers ([f5e1b9a](f5e1b9a))
* renameing identity.Reset so it doesn't override unity's reset function ([bc5da6a](bc5da6a))
* using hex for logging prefabhash and sceneid ([f0c335f](f0c335f))

### Code Refactoring

* **NetworkIdentity:** moving id generation to its own file ([51795ce](51795ce))

### Features

* **NetworkIdentity:** adding helper methods for Id ([0ddfdb8](0ddfdb8))
* **ServerObjectManager:** adding AddCharacter method that takes Identity and hash ([629036a](629036a))
* **ServerObjectManager:** adding ReplaceCharacter method  that takes Identity and hash ([4320c05](4320c05))

### Performance Improvements

* making transform values option to send with spawn message ([#972](#972)) ([22e7dcd](22e7dcd))
* no longer sending PrefabHash if the object is a scene id ([46e29a6](46e29a6))

### BREAKING CHANGES

* Scene objects based on a prefab will no longer have their PrefabHash set on spawn on the client
* **NetworkIdentity:** Scene Id generation is no longer public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts Pull Request has merge conflicts released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant