Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: this implements performance testing for current aoi system #988

Closed
wants to merge 17 commits into from

Conversation

dragonslaya84
Copy link
Member

No description provided.

@dragonslaya84 dragonslaya84 added the keep-open Stops issue being closed because it is stale label Nov 7, 2021
James-Frowen and others added 15 commits November 7, 2021 11:55
…nction

Unity uses the Reset method when doing right click reset. If we override it then we can't reset the ids manually if something goes wrong
BREAKING CHANGE: Scene Id generation is no longer public
Mirage will never need both scene id and prefab hash, so we never need to send both of them.

also using new networkidentity helper properties else where too

BREAKING CHANGE: Scene objects based on a prefab will no longer have their PrefabHash set on spawn on the client
Not all objects need their transform values synced when they are spawned.
And many object have it sent twice because the values will also be sent by NT.

This adds the option to disable syncing position for some Identities by disabling the option in the inspector. The values default to true so this will not break any existing projects.

This also makes the values in spawn message nullable so they will take up 3 bits extra when they are all synced. But this should not increase the otherall size because writing the payload will padd to the nearest byte. and there are already 2 bools in this struct
# [112.0.0](v111.1.1...v112.0.0) (2021-11-07)

### Bug Fixes

* adding a check to make sure asset id isn't created from empty string ([26a5bbc](26a5bbc))
* fixing defines for Unity2021.2 ([#977](#977)) ([15ffa5b](15ffa5b))
* fixing id generation for negative numbers ([f5e1b9a](f5e1b9a))
* renameing identity.Reset so it doesn't override unity's reset function ([bc5da6a](bc5da6a))
* using hex for logging prefabhash and sceneid ([f0c335f](f0c335f))

### Code Refactoring

* **NetworkIdentity:** moving id generation to its own file ([51795ce](51795ce))

### Features

* **NetworkIdentity:** adding helper methods for Id ([0ddfdb8](0ddfdb8))
* **ServerObjectManager:** adding AddCharacter method that takes Identity and hash ([629036a](629036a))
* **ServerObjectManager:** adding ReplaceCharacter method  that takes Identity and hash ([4320c05](4320c05))

### Performance Improvements

* making transform values option to send with spawn message ([#972](#972)) ([22e7dcd](22e7dcd))
* no longer sending PrefabHash if the object is a scene id ([46e29a6](46e29a6))

### BREAKING CHANGES

* Scene objects based on a prefab will no longer have their PrefabHash set on spawn on the client
* **NetworkIdentity:** Scene Id generation is no longer public
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
@github-actions github-actions bot added the has conflicts Pull Request has merge conflicts label Nov 7, 2021
@dragonslaya84 dragonslaya84 deleted the InterestManagerBenchmarking branch November 7, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts Pull Request has merge conflicts keep-open Stops issue being closed because it is stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants