Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the sandbox image status as "Pinned" #194

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

afbjorklund
Copy link
Contributor

@afbjorklund afbjorklund commented Jun 1, 2023

Upgrade CRI API from v0.22.8 to v0.23.0 in order to get "pinned"

TODO: PodSandboxStats
TODO: ListPodSandboxStats

Upgrade default sandbox image to registry.k8s.io/pause:3.9


Review

commit 72cfd7c

@afbjorklund

This comment was marked as outdated.

core/stats.go Outdated Show resolved Hide resolved
@nwneisen
Copy link
Collaborator

@afbjorklund Can I have you rebase again now that the unit tests are fixed and running in CI?

This means that the kubelet should not try to delete
this image, as has been configured by the runtime.
Copy link
Collaborator

@nwneisen nwneisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwneisen nwneisen merged commit 0bcf1ae into Mirantis:master Jan 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants