[1.30] Remove depracated pod-infra-container-image kubelet flag

[dereknola]

Proposed Changes

• Stops passing pause image to kubelet as a flag (deprecated in v1.29.0)

Types of Changes

CLI

Verification

Start k3s with --pause-image=rancher/mirrored-pause:3.5 and check the logs for the kubelet command. Should see no complaints from kubelet.

Testing

Linked Issues

#7408

User-Facing Change

Further Comments

[brandond]

We should confirm that the containerd CRI implementation actually exposes this and it is used by the kubelet; CRI related warnings from the kubelet are not always in sync with the reality of CRI implementation maturity.

[dereknola]

Good call Brad, looking around, it appears that containerd has the proper implementation, but crio and cri-dockerd are not yet fully implemented. Seems this has been pushed off until 1.28 for upstream. I am converting this to a draft until that has been resolved.

crio: cri-o/cri-o#6816
cri-dockerd: Mirantis/cri-dockerd#178

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.73%. Comparing base (fe7d114) to head (4126aa6).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7409      +/-   ##
==========================================
- Coverage   48.92%   40.73%   -8.19%     
==========================================
  Files         158      158              
  Lines       14032    14030       -2     
==========================================
- Hits         6865     5715    -1150     
- Misses       5885     7272    +1387     
+ Partials     1282     1043     -239     

Flag	Coverage Δ
e2etests	35.82% <ø> (-10.97%)	⬇️
inttests	32.18% <ø> (?)
unittests	16.58% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cwayne18]

Should we check with @Oats87 and co to ensure they're prepared for this

[brandond]

You mentioned earlier that cri-dockerd didn't support this yet, do we need to bump the embedded cri-dockerd version as part of this?

[dereknola]

Good catch, it seems that they still have not implemented this and that full removal has moved back to 1.30
CRI-DOCKERD issue: Mirantis/cri-dockerd#39
K8s Deprecation Update (mentioning 1.30 now): kubernetes/kubernetes@d5690f1

[afbjorklund]

There is a PR, if you want to patch your fork. Main issue is that cri-dockerd is still using the 1.22 API

• Return the sandbox image status as "Pinned" Mirantis/cri-dockerd#194

[brandond]

@afbjorklund we might take a look at pulling that in. Our fork already upgrades the CRI API and stubs out the metrics calls - although we do it by just returning an Unimplemented error, instead of returning empty/zero metrics like the current upstream PR appears to do.

[afbjorklund]

Probably a better idea, it's been a few months now since that initial hack

[dereknola]

cri-dockerd has support as of v0.3.10, so 1.30 will see this merged.

[VestigeJ]

LGTM