Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch stat logging to debugf() #259

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

nwneisen
Copy link
Collaborator

@nwneisen nwneisen commented Oct 16, 2023

Fixes #258

Logs before making this change:

Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Connecting to docker on the Endpoint unix:///var/run/docker.sock"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Start docker client with request timeout 0s"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Hairpin mode is set to hairpin-veth"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Loaded network plugin cni"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Docker cri networking managed by network plugin cni"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Setting cgroupDriver systemd"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Docker cri received runtime config &RuntimeConfig{NetworkConfig:&NetworkConfig{PodCidr:,},}"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Starting the GRPC backend for the Docker CRI interface."
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Start cri-dockerd grpc backend"
...
Oct 16 16:02:01 minikube cri-dockerd[2695]: time="2023-10-16T16:02:01Z" level=info msg="Number of pod containers: 8"
Oct 16 16:02:02 minikube cri-dockerd[2695]: time="2023-10-16T16:02:02Z" level=info msg="End ListContainerStats. Number of stats:8, Time taken: 1.010881467s"
Oct 16 16:02:12 minikube cri-dockerd[2695]: time="2023-10-16T16:02:12Z" level=info msg="Begin ListContainerStats"
Oct 16 16:02:12 minikube cri-dockerd[2695]: time="2023-10-16T16:02:12Z" level=info msg="Number of pod containers: 8"
Oct 16 16:02:13 minikube cri-dockerd[2695]: time="2023-10-16T16:02:13Z" level=info msg="End ListContainerStats. Number of stats:8, Time taken: 1.019785021s"
Oct 16 16:02:23 minikube cri-dockerd[2695]: time="2023-10-16T16:02:23Z" level=info msg="Filesystem usage containing '/var/lib/docker': usedBytes=214736613376, iNodesUsed=4770289"
Oct 16 16:02:23 minikube cri-dockerd[2695]: time="2023-10-16T16:02:23Z" level=info msg="Total used bytes by docker images: 736076745"
Oct 16 16:02:23 minikube cri-dockerd[2695]: time="2023-10-16T16:02:23Z" level=info msg="Begin ListContainerStats"
Oct 16 16:02:23 minikube cri-dockerd[2695]: time="2023-10-16T16:02:23Z" level=info msg="Number of pod containers: 8"
Oct 16 16:02:24 minikube cri-dockerd[2695]: time="2023-10-16T16:02:24Z" level=info msg="End ListContainerStats. Number of stats:8, Time taken: 1.019527026s"
....

Logs after:

Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Connecting to docker on the Endpoint unix:///var/run/docker.sock"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Start docker client with request timeout 0s"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Hairpin mode is set to hairpin-veth"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Loaded network plugin cni"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Docker cri networking managed by network plugin cni"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Setting cgroupDriver systemd"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Docker cri received runtime config &RuntimeConfig{NetworkConfig:&NetworkConfig{PodCidr:,},}"
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Starting the GRPC backend for the Docker CRI interface."
Oct 16 16:30:14 minikube cri-dockerd[3700]: time="2023-10-16T16:30:14Z" level=info msg="Start cri-dockerd grpc backend"

Proposed Changes

  • Change stats logging calls to debugf()

@nwneisen nwneisen changed the title Switch logging to debugf() from infof() Switch stat logging to debugf() Oct 16, 2023
@nwneisen nwneisen added the bug Something isn't working label Oct 16, 2023
@nwneisen nwneisen merged commit cd730ff into Mirantis:master Oct 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New stats infof() calls flood the logs
2 participants