-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Testing k8s 1.4 on travis with go 1.7 #252
Open
pigmej
wants to merge
26
commits into
Mirantis:master
Choose a base branch
from
pigmej:test_1_4with_1_7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of running ac-run inside of the appcontroller pod user will have to create documented config map with several fields (concurrency, labels selector). appcontroller process will listen to changes for that config map and run deployment graph processing, on deletion of configmap we will terminate deployment workflow. It will allow us to provide guarantees that workflow will be finished even if appcontroller pod will crash.
Updated roadmap in readme
Bump k8s on CI to 1.5.4 and 1.4.9
Refactor appcontroller to work as long running controller
This is mainly required for tests and not supposed to be used on production
Use kubeadm on CI and make it work on kube 1.6
Remove all runit related scripts
- Add copyright notices - Currently, CI pushing images only with latest tag: https://travis-ci.org/Mirantis/k8s-AppController/jobs/203410745#L1998-L2001 No one paid attention to this, because the "after_success" step failure doesn't fail build: travis-ci/travis-ci#758 And at the moment a good fix is to use this as the last entry of "script" step instead of "after_success" step.
- Fixed syntax
Fixed docker publish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)