WIP: Heat provisioner #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkukral
commented
Oct 2, 2017
kqueen/provisioners/heat.py
Outdated
| from keystoneauth1.identity import v3 | ||
| from keystoneauth1 import session | ||
| import heatclient | ||
| import heatclient.client |
There was a problem hiding this comment.
Can you plesae add these dependencies to requirements.txt file?
sort imports be consistent with quotes
rwngwn
reviewed
Oct 12, 2017
| if cacheEnabled and cache.get(cluster_id): | ||
| return cache.get(cluster_id) | ||
|
|
||
| if cluster_id in self.clusters: |
There was a problem hiding this comment.
you can negate here, so it will be
if clusterd_id not in self.clusters:
logger.error('Cluster {} not managed by this provisioner'.format(cluster_id))
return Noneand continue with less nesting.
| return self.clusters | ||
|
|
||
| def delete(self, cluster_id): | ||
| if cluster_id in self.clusters: |
There was a problem hiding this comment.
again if you negate and return code will be much easier to read
|
|
||
| try: | ||
| # Create stack | ||
| r = self.__create_stack(stack_name, template, merged_files, merged_env) |
There was a problem hiding this comment.
is the 'r' used somewhere? also do not use one letter names.
| from heatclient.common import template_utils | ||
|
|
||
| import logging | ||
| from werkzeug.contrib.cache import SimpleCache |
ekhomyakova
pushed a commit
that referenced
this pull request
Sep 4, 2018
Provisioning animated loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Heat provisioner