Add unique username check #275
Conversation
katyafervent
force-pushed
the
add-unique-username-check
branch
6 times, most recently
from
bf78c4e
to
1a29d94
Compare
|
failed flake8 |
katyafervent
force-pushed
the
add-unique-username-check
branch
13 times, most recently
from
6b21898
to
467dd11
Compare
katyafervent
force-pushed
the
add-unique-username-check
branch
from
467dd11
to
be346a6
Compare
* Make user username and email unique
* clear database after each test class execution
* So all resources such as database objects wil be cleaned after each test * Delete objects, created in tests * Fix modifying env variables (monkeypatching that is used previously changes it for the whole session, so it affects other tests)
katyafervent
force-pushed
the
add-unique-username-check
branch
from
be346a6
to
efc4926
Compare
| @@ -634,6 +636,14 @@ def validate(self): | |||
| if field_object.required and field_object.value is None: | |||
| return False, 'Required field {} is None'.format(field) | |||
|
|
|||
| if field_object.unique and field_object.value: | |||
There was a problem hiding this comment.
from line 639 to 646
Does it really iterate over all objects in the namespace?
I don't see any concurrency checks or sth, so wouldn't it just work not ok in concurrent environments? (I'm pretty sure that it will allow to create objects with unique that is not unique at all.
(I'm not kqueen expert though)
There was a problem hiding this comment.
The iteration started at 630 line witch is not shown here, validate method is called on every obj save, so if you try to add obj with field that should be unique but not, validation will failed and obj won't save.
There was a problem hiding this comment.
If you will create the same key twice and try to save them in the same moment, you have high chances to create it regardless of that check. This operation is not atomic and not thread / process safe.
There was a problem hiding this comment.
I'm planning to add lock on save operation, will that work?) https://github.com/jplana/python-etcd#locking-module
No description provided.