Add override parameters to Jenkins #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekhomyakova
reviewed
May 16, 2018
kqueen/engines/jenkins.py
Outdated
| 'override_parameters': { | ||
| 'type': 'parameters', | ||
| 'label': 'Jenkins job parameters', | ||
| 'order': 1, |
kqueen/engines/jenkins.py
Outdated
| 'label': 'Jenkins job parameters', | ||
| 'order': 1, | ||
| 'validators': { | ||
| 'required': False |
There was a problem hiding this comment.
yes, default is required
kqueen/engines/jenkins.py
Outdated
| logger.exception('Could not contact JenkinsEngine backend: ') | ||
| status = config.get('PROVISIONER_ERROR_STATE') | ||
| return status | ||
| Check, that key parameter, defined by |
There was a problem hiding this comment.
Check that key parameter defined by
kqueen/engines/jenkins.py
Outdated
| Returns: | ||
| :obj:`jenkins.Jenkins`: initialized Jenkins client | ||
| """ | ||
| return jenkins.Jenkins(self.jenkins_url, **{ |
There was a problem hiding this comment.
Why don't you pass it in a normal way?
kqueen/engines/jenkins.py
Outdated
| try: | ||
| job_body = self.client.get_job_info(self.provision_job_name, depth=1) | ||
| for jj_class in job_body['property']: | ||
| if 'parameterDefinitions' not in jj_class.keys(): |
kqueen/engines/jenkins.py
Outdated
| if self.job_override_params: | ||
| logger.debug('The following job parameters will be overwritten: {}' | ||
| .format(self.job_override_params)) | ||
| for key, value in self.job_override_params.items(): |
There was a problem hiding this comment.
ctx.update(self.job_override_params) ?
There was a problem hiding this comment.
Have you tried this? It should work
naumvd95
reviewed
May 17, 2018
| @@ -227,7 +227,7 @@ def dispatch_request(self, *args, **kwargs): | |||
| self.save_object() | |||
| self.after_save() | |||
| except Exception as e: | |||
| current_app.logger.error(e) | |||
| current_app.logger.exception(e) | |||
There was a problem hiding this comment.
e is redundant, coz it in that way traceback will be duplicated
There was a problem hiding this comment.
No, not in that case this is general logging, we don't log exceptions everywhere so this is the one way to get info about exception.
kqueen/engines/jenkins.py
Outdated
|
|
||
| Returns: | ||
| :obj:`jenkins.Jenkins`: initialized Jenkins client | ||
| bool: True if all parameters exist |
There was a problem hiding this comment.
remove all
this method takes 1 arg
katyafervent
force-pushed
the
add-override-parameters-to-jenkins
branch
from
f79520f
to
a710908
Compare
katyafervent
force-pushed
the
add-override-parameters-to-jenkins
branch
from
a710908
to
340827a
Compare
ekhomyakova
reviewed
May 18, 2018
| if auth_verify: | ||
| status = config.get('PROVISIONER_OK_STATE') | ||
| except Exception as e: | ||
| logger.exception('Could not contact JenkinsEngine backend: ') |
There was a problem hiding this comment.
It's just code movement, not a scope of this commit
Use cases: 1) Calico managing in case of using mcp-job calico-ha-aws-k8s 2) Overriding parameters in case of any jenkins job
katyafervent
force-pushed
the
add-override-parameters-to-jenkins
branch
from
340827a
to
3f88bae
Compare
ekhomyakova
approved these changes
May 21, 2018
naumvd95
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.