Refactor EKS #317
Merged
Refactor EKS #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems its related to security policies, coz |
|
Seems its related to istio/istio#5327 |
|
Please, remove traceback from the commit message, looks huge in a git history |
katyafervent
suggested changes
Jun 9, 2018
kqueen/engines/eks.py
Outdated
| # Cluster settings | ||
| self.role_arn = kwargs['role_arn'] | ||
| subnets = kwargs['subnet_id'] | ||
| self.subnet_id = subnets.split(',') |
kqueen/engines/eks.py
Outdated
| subnets = kwargs['subnet_id'] | ||
| self.subnet_id = subnets.split(',') | ||
| security_groups = kwargs.get('security_group_id', '') | ||
| self.security_group_id = security_groups.split(',') |
kqueen/engines/eks.py
Outdated
| aws_secret_key = kwargs.get('aws_secret_key', '') | ||
| aws_access_key = kwargs['aws_access_key'] | ||
| aws_secret_key = kwargs['aws_secret_key'] | ||
| aws_region = kwargs['aws_region'] | ||
| except Exception: |
There was a problem hiding this comment.
We expected KeyError here, I think we should except that type of exception and do not log it, just log message, that credentials are missed
- Template structure defined - Kubeconfig download fixed - Cluster states fixed - Engine status fixed - TODO added current issue related with kqueen-k8s-api methods: ``` api_1 | Traceback (most recent call last): api_1 | File "/code/kqueen/models.py", line 124, in status api_1 | 'addons': kubernetes.list_services(filter_addons=True), api_1 | File "/code/kqueen/kubeapi.py", line 238, in list_services api_1 | include_uninitialized=include_uninitialized api_1 | File "/usr/local/lib/python3.6/site-packages/kubernetes/client/apis/core_v1_api.py", line 14358, in list_service_for_all_namespaces api_1 | (data) = self.list_service_for_all_namespaces_with_http_info(**kwargs) api_1 | File "/usr/local/lib/python3.6/site-packages/kubernetes/client/apis/core_v1_api.py", line 14455, in list_service_for_all_namespaces_with_http_info api_1 | collection_formats=collection_formats) api_1 | File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 321, in call_api api_1 | _return_http_data_only, collection_formats, _preload_content, _request_timeout) api_1 | File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 155, in __call_api api_1 | _request_timeout=_request_timeout) api_1 | File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 342, in request api_1 | headers=headers) api_1 | File "/usr/local/lib/python3.6/site-packages/kubernetes/client/rest.py", line 231, in GET api_1 | query_params=query_params) api_1 | File "/usr/local/lib/python3.6/site-packages/kubernetes/client/rest.py", line 222, in request api_1 | raise ApiException(http_resp=r) api_1 | kubernetes.client.rest.ApiException: (403) ``` faced when try to parse k8s config body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current issue related with kqueen-k8s-api methods:
faced when try to parse k8s config body