Fix deprovisioning PVC in kubespray engine #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naumvd95
reviewed
Jul 2, 2018
| self.ks.delete() | ||
| except Exception as e: | ||
| logger.warn("Unable to cleanup cluster data: %s" % e) | ||
| self.cluster.state = config.CLUSTER_ERROR_STATE |
There was a problem hiding this comment.
afaik we need to use logger exception here^^^
|
@redixin take a look on comment and rebase manually before merge , coz branch outdated |
redixin
force-pushed
the
kubespray-volumes
branch
from
6820a7f
to
a703c23
Compare
svnovikov
previously approved these changes
Jul 3, 2018
naumvd95
previously approved these changes
Jul 4, 2018
redixin
force-pushed
the
kubespray-volumes
branch
from
fc4e2b5
to
ef95103
Compare
katyafervent
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volumes created by k8s cluster should be deleted along with cluster itself