Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider some additional fields while sorting #335

Merged
merged 1 commit into from Jul 9, 2018
Merged

Conversation

ekhomyakova
Copy link

If you sort only by one key, then in case of objects with
similar fields order can be randomly changed after page switching.
To avoid this, sort by id was added. Also sorting by name was added
for more readability.

naumvd95
naumvd95 previously approved these changes Jul 9, 2018
Copy link
Contributor

@naumvd95 naumvd95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM, does it checked?

If you sort only by one key, then in case of objects with
similar fields order can be randomly changed after page switching.
To avoid this, sort by id was added. Also sorting by name was added
for more readability.
Copy link
Contributor

@svnovikov svnovikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified and works for me

@katyafervent katyafervent merged commit 9fececb into master Jul 9, 2018
@katyafervent katyafervent deleted the sorting branch July 30, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants