Improve os kubespray #357
Merged
Improve os kubespray #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katyafervent
force-pushed
the
improve-os-kubespray
branch
from
02d7796
to
c5d2da0
Compare
katyafervent
force-pushed
the
improve-os-kubespray
branch
8 times, most recently
from
0ee2c08
to
509518a
Compare
naumvd95
suggested changes
Sep 11, 2018
| @@ -711,6 +716,9 @@ def provision(self): | |||
| image=self.meta['image'], | |||
| flavor=self.meta['master_flavor'], | |||
| network=network): | |||
| if master.status == 'ERROR': | |||
| raise RuntimeError('Could not spawn the instance. Check Openstack logs') | |||
There was a problem hiding this comment.
specify master.id or smth similar to point user into specific instance logs
| @@ -725,6 +733,8 @@ def provision(self): | |||
| flavor=self.meta['slave_flavor'], | |||
| network=network, | |||
| add_random_suffix=True): | |||
| if slave.status == 'ERROR': | |||
| raise RuntimeError('Could not spawn the instance. Check Openstack logs') | |||
There was a problem hiding this comment.
specify slave.id or smth similar to point user into specific instance logs
added 4 commits
September 11, 2018 18:26
katyafervent
force-pushed
the
improve-os-kubespray
branch
from
509518a
to
42e3efc
Compare
naumvd95
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.