Add longevity tests #705

lukaszo · 2018-06-29T08:54:49Z

This change is

jellonek · 2018-07-02T08:17:32Z

Reviewed 23 of 23 files at r1.
Review status: 0 of 2 LGTMs obtained

tests/e2e/common.go, line 44 at r1 (raw file):

)

// schedulewaitSSH schedules SSH interface initialization before the test context starts

What is the reason behind this rename?

tests/longevity/checks.go, line 1 at r1 (raw file):

package longevity

Missing copyrights header.

tests/longevity/checks.go, line 104 at r1 (raw file):

			err = localExecutor.Run(nil, &stdout, &stdout, "kubectl", "-n", controller.Namespace(), "logs", vm.Name)
			if err != nil {
				err = fmt.Errorf("Failed to run `kubectl -n %s logs %s: %v. Stdout: %s", controller.Namespace(), vm.Name, err, stdout.String())

That will overwrite a previous value of err without displaying it. It would be better to collect them in slice and return an empty one if everything is ok.

tests/longevity/checks.go, line 118 at r1 (raw file):

			return err
		}
	*/

Commented code leaved in PR.

tests/longevity/runner.go, line 2 at r1 (raw file):

/*
Copyright 2017 Mirantis

2018

tests/longevity/tools.go, line 1 at r1 (raw file):

package longevity

Missing copyrights header.

tests/longevity/vmcontoller.go, line 1 at r1 (raw file):

package longevity

Missing copyrights header.

tests/longevity/vmcontoller.go, line 31 at r1 (raw file):

		select {
		case <-ctx.Done():
			glog.V(3).Infof("Testing '%s' VM stopped\n", instance.name)

Why you are adding "\n" there? It's unusual in logs if there is nothing added after it.

tests/longevity/vmcontoller.go, line 34 at r1 (raw file):

			return
		case <-instance.testTicker.C:
			glog.V(3).Infof("Testing '%s' VM...\n", instance.name)

Same as above.

tests/longevity/vmcontoller.go, line 37 at r1 (raw file):

			err = testFunc(instance)
			if err != nil {
				glog.V(5).Infof("Test function failed with: %v, instance: %+v", err, instance)

Why there is 5th level instead commonly used above 3?

tests/longevity/vmcontoller.go, line 46 at r1 (raw file):

			}
		case <-instance.lifetimeTicker.C:
			glog.V(5).Infof("Recreating VM: %s", instance.name)

Same as above.

tests/longevity/vmcontoller.go, line 49 at r1 (raw file):

			err = instance.ReCreate()
			if err != nil {
				glog.V(5).Infof("Recreating VM %s failed:%v", instance.name, err)

Same as above and missing space after ":".

Comments from Reviewable

lukaszo

Reviewable status: 0 of 2 LGTMs obtained

tests/e2e/common.go, line 44 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

What is the reason behind this rename?

What rename?

tests/longevity/checks.go, line 1 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Missing copyrights header.

Done.

tests/longevity/checks.go, line 104 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

That will overwrite a previous value of err without displaying it. It would be better to collect them in slice and return an empty one if everything is ok.

I only care about last error when loop ended

tests/longevity/checks.go, line 118 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Commented code leaved in PR.

yeah, I'm not sure what to do here. The code is ok but for some reason attach doesn't work. It worked earlier. There will be a bug for it.

tests/longevity/runner.go, line 2 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

2018

Done.

tests/longevity/tools.go, line 1 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Missing copyrights header.

Done.

tests/longevity/vmcontoller.go, line 1 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Missing copyrights header.

Done.

tests/longevity/vmcontoller.go, line 31 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Why you are adding "\n" there? It's unusual in logs if there is nothing added after it.

I had printf there earlier and forgot to clean it.
Done

tests/longevity/vmcontoller.go, line 34 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Same as above.

Done.

tests/longevity/vmcontoller.go, line 37 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Why there is 5th level instead commonly used above 3?

hmm, 5 I'm using for debugging. Should I change it?

jellonek

Reviewable status: 0 of 2 LGTMs obtained

tests/e2e/common.go, line 44 at r1 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

What rename?

scheduleWait to shedulewait. change of case.

tests/longevity/checks.go, line 118 at r1 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

yeah, I'm not sure what to do here. The code is ok but for some reason attach doesn't work. It worked earlier. There will be a bug for it.

Ok.

tests/longevity/vmcontoller.go, line 37 at r1 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

hmm, 5 I'm using for debugging. Should I change it?

IMO it should be consistent with other places where you have 3.

lukaszo

Reviewable status: 0 of 2 LGTMs obtained

tests/e2e/common.go, line 44 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

scheduleWait to shedulewait. change of case.

Done.

tests/longevity/checks.go, line 118 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Ok.

ah, wrong sed. fixing :)

tests/longevity/vmcontoller.go, line 37 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

IMO it should be consistent with other places where you have 3.

Done.

tests/longevity/vmcontoller.go, line 46 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Same as above.

Done.

tests/longevity/vmcontoller.go, line 49 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Same as above and missing space after ":".

Done.

jellonek

Reviewed 11 of 11 files at r2.
Reviewable status: 0 of 2 LGTMs obtained

tests/longevity/checks.go, line 118 at r1 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

ah, wrong sed. fixing :)

So it looks like last thing for me ;)

lukaszo

Reviewable status: 0 of 2 LGTMs obtained

tests/longevity/checks.go, line 118 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

So it looks like last thing for me ;)

should I just remove it for now?

jellonek

Reviewable status: 0 of 2 LGTMs obtained

tests/longevity/checks.go, line 118 at r1 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

should I just remove it for now?

If it's possible - please fix it, or remove comment. Commented code blocks have tend to be more and more smelly over the time. It can be added later, after fixing, as a follow up.

lukaszo

Reviewable status: 0 of 2 LGTMs obtained

tests/longevity/checks.go, line 118 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

If it's possible - please fix it, or remove comment. Commented code blocks have tend to be more and more smelly over the time. It can be added later, after fixing, as a follow up.

done

jellonek

Reviewed 1 of 1 files at r3.
Reviewable status: 0 of 2 LGTMs obtained, and 1 stale

ivan4th

Reviewed 10 of 23 files at r1, 8 of 11 files at r2.
Reviewable status: 1 of 2 LGTMs obtained

cmd/longevity/longevity.go, line 38 at r2 (raw file):

	if err != nil {
		glog.Infof("Fatal: %v\n", err)
		os.Exit(1)

Maybe can just use glog.Fatal(err) ? Or, at least, use glog.Errorf

cmd/longevity/longevity.go, line 53 at r2 (raw file):

	if err != nil {
		glog.Infof("Fatal: %v\n", err)
		os.Exit(1)

Same as above.

lukaszo

Reviewable status: 0 of 2 LGTMs obtained, and 1 stale

cmd/longevity/longevity.go, line 38 at r2 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

Maybe can just use glog.Fatal(err) ? Or, at least, use glog.Errorf

Done.

cmd/longevity/longevity.go, line 53 at r2 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

Same as above.

Done.

ivan4th

Reviewable status: 0 of 2 LGTMs obtained, and 1 stale

cmd/longevity/longevity.go, line 38 at r2 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

Done.

glog.Fatal() exits by itself ;(

ivan4th

Reviewable status: 0 of 2 LGTMs obtained, and 1 stale

cmd/longevity/longevity.go, line 53 at r2 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

Done.

same ...

lukaszo

Reviewable status: 0 of 2 LGTMs obtained, and 1 stale

cmd/longevity/longevity.go, line 38 at r2 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

glog.Fatal() exits by itself ;(

done

cmd/longevity/longevity.go, line 53 at r2 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

same ...

done

ivan4th

Reviewed 4 of 4 files at r5.
Reviewable status: 0 of 2 LGTMs obtained, and 1 stale

ivan4th

Reviewable status: 0 of 2 LGTMs obtained, and 2 stale

ivan4th

Reviewable status: 1 of 2 LGTMs obtained, and 1 stale

ivan4th

Reviewed 1 of 1 files at r6.
Reviewable status: 0 of 2 LGTMs obtained, and 2 stale

ivan4th

Reviewable status: 0 of 2 LGTMs obtained, and 2 stale

jellonek

Reviewed 4 of 4 files at r5, 1 of 1 files at r6.
Reviewable status: 1 of 2 LGTMs obtained, and 1 stale

lukaszo changed the title ~~[WiP]Add longevity tests~~ Add longevity tests Jul 2, 2018

lukaszo commented Jul 4, 2018

View reviewed changes

jellonek suggested changes Jul 5, 2018

View reviewed changes

lukaszo commented Jul 5, 2018

View reviewed changes

jellonek suggested changes Jul 5, 2018

View reviewed changes

lukaszo commented Jul 9, 2018

View reviewed changes

jellonek suggested changes Jul 9, 2018

View reviewed changes

lukaszo commented Jul 9, 2018

View reviewed changes

jellonek approved these changes Jul 9, 2018

View reviewed changes

jellonek reviewed Jul 9, 2018

View reviewed changes

ivan4th suggested changes Jul 10, 2018

View reviewed changes

lukaszo commented Jul 10, 2018

View reviewed changes

ivan4th suggested changes Jul 10, 2018

View reviewed changes

lukaszo commented Jul 11, 2018

View reviewed changes

ivan4th approved these changes Jul 11, 2018

View reviewed changes

Add longevity tests

239a80e

ivan4th approved these changes Jul 11, 2018

View reviewed changes

jellonek approved these changes Jul 11, 2018

View reviewed changes

jellonek merged commit 2d3ebd0 into Mirantis:master Jul 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add longevity tests #705

Add longevity tests #705

lukaszo commented Jun 29, 2018 •

edited by pigmej

Loading

jellonek commented Jul 2, 2018

lukaszo left a comment

jellonek left a comment

lukaszo left a comment

jellonek left a comment

lukaszo left a comment

jellonek left a comment

lukaszo left a comment

jellonek left a comment

ivan4th left a comment

lukaszo left a comment

ivan4th left a comment

ivan4th left a comment

lukaszo left a comment

ivan4th left a comment

ivan4th left a comment

ivan4th left a comment

ivan4th left a comment

ivan4th left a comment

jellonek left a comment

Add longevity tests #705

Add longevity tests #705

Conversation

lukaszo commented Jun 29, 2018 • edited by pigmej Loading

jellonek commented Jul 2, 2018

lukaszo left a comment

Choose a reason for hiding this comment

jellonek left a comment

Choose a reason for hiding this comment

lukaszo left a comment

Choose a reason for hiding this comment

jellonek left a comment

Choose a reason for hiding this comment

lukaszo left a comment

Choose a reason for hiding this comment

jellonek left a comment

Choose a reason for hiding this comment

lukaszo left a comment

Choose a reason for hiding this comment

jellonek left a comment

Choose a reason for hiding this comment

ivan4th left a comment

Choose a reason for hiding this comment

lukaszo left a comment

Choose a reason for hiding this comment

ivan4th left a comment

Choose a reason for hiding this comment

ivan4th left a comment

Choose a reason for hiding this comment

lukaszo left a comment

Choose a reason for hiding this comment

ivan4th left a comment

Choose a reason for hiding this comment

ivan4th left a comment

Choose a reason for hiding this comment

ivan4th left a comment

Choose a reason for hiding this comment

ivan4th left a comment

Choose a reason for hiding this comment

ivan4th left a comment

Choose a reason for hiding this comment

jellonek left a comment

Choose a reason for hiding this comment

lukaszo commented Jun 29, 2018 •

edited by pigmej

Loading