Fix demo.sh for MULTI_CNI #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As demo::install-cri-proxy() causes a restart of the pods, it should be done before demo::install-cni-genie(). Otherwise the modifications done by demo::jq-patch() to /etc/cni/net.d get overwritten. Signed-off-by: Gregory Vander Schueren <gregory.vanderschueren@tessares.net>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
pigmej
approved these changes
Oct 4, 2019
There was a problem hiding this comment.
LGTM
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
pigmej
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As demo::install-cri-proxy() causes a restart of the pods, it should
be done before demo::install-cni-genie(). Otherwise the modifications
done by demo::jq-patch() to /etc/cni/net.d get overwritten.
Signed-off-by: Gregory Vander Schueren gregory.vanderschueren@tessares.net
Also, I noticed the MULTI_CNI demo runs with a single host. Is there any reason not to run it with 2 hosts like the regular demo? I would be interested in modifying it to have 2 hosts. Will I run into troubles if I do so? Thanks.
This change is