Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demo.sh for MULTI_CNI #889

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@GregoryVds
Copy link
Contributor

commented Jun 20, 2019

As demo::install-cri-proxy() causes a restart of the pods, it should
be done before demo::install-cni-genie(). Otherwise the modifications
done by demo::jq-patch() to /etc/cni/net.d get overwritten.

Signed-off-by: Gregory Vander Schueren gregory.vanderschueren@tessares.net

Also, I noticed the MULTI_CNI demo runs with a single host. Is there any reason not to run it with 2 hosts like the regular demo? I would be interested in modifying it to have 2 hosts. Will I run into troubles if I do so? Thanks.


This change is Reviewable

As demo::install-cri-proxy() causes a restart of the pods, it should
be done before demo::install-cni-genie(). Otherwise the modifications
done by demo::jq-patch() to /etc/cni/net.d get overwritten.

Signed-off-by: Gregory Vander Schueren <gregory.vanderschueren@tessares.net>
@stale

This comment has been minimized.

Copy link

commented Aug 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 4, 2019
@stale stale bot closed this Aug 11, 2019
@pigmej pigmej reopened this Aug 18, 2019
@stale stale bot removed the wontfix label Aug 18, 2019
@stale

This comment has been minimized.

Copy link

commented Oct 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 2, 2019
@jellonek

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

@pigmej @ivan4th PTAL and merge or reopen that.

@stale stale bot removed the wontfix label Oct 3, 2019
@pigmej
pigmej approved these changes Oct 4, 2019
Copy link
Member

left a comment

LGTM

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@pigmej
pigmej approved these changes Oct 4, 2019
Copy link
Member

left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@pigmej pigmej merged commit b3e72ad into Mirantis:master Oct 4, 2019
12 checks passed
12 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/circleci: e2e Your tests passed on CircleCI!
Details
ci/circleci: e2e_1_13 Your tests passed on CircleCI!
Details
ci/circleci: e2e_calico Your tests passed on CircleCI!
Details
ci/circleci: integration Your tests passed on CircleCI!
Details
ci/circleci: prepare_build Your tests passed on CircleCI!
Details
ci/circleci: push_branch Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
code-review/reviewable 1 of 1 ✓
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.